Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: slackapi/python-slack-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.18.0
Choose a base ref
...
head repository: slackapi/python-slack-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.18.1
Choose a head ref
  • 4 commits
  • 30 files changed
  • 3 contributors

Commits on Jul 22, 2022

  1. Tweak aiohttp documentation

    srajiang authored and seratch committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    7dc8689 View commit details
    Browse the repository at this point in the history
  2. Add generated docs files

    srajiang authored and seratch committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    e24c270 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. rtm_v2 api spins in infinite loop under gevent (#1246)

    * Raise an exception when reading from socket and getting no data.
    Returning and empty bytes object causes an infinite loop between this and the
    fetch function which in some cases can cause 100% cpu utilization (this happens
    under gevent). Also the exception handling here can't just return an empty bytes for the same
    reason - the now dead connection cannot be replaced by code that uses this
    code.
    
    * Per https://docs.python.org/3/howto/sockets.html
    No data means the other side has closed the connection:
    "When a recv returns 0 bytes, it means the other side has closed (or is in the
    process of closing) the connection. You will not receive any more data on this
    connection. Ever. You may be able to send data successfully"
    mattbillenstein authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    fcb137b View commit details
    Browse the repository at this point in the history
  2. version 3.18.1

    seratch committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f895432 View commit details
    Browse the repository at this point in the history
Loading