Skip to content

Commit f65d89b

Browse files
committed
Drop SQLAlchemy v1.3 support ref #1337
1 parent 84e1169 commit f65d89b

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.github/workflows/ci-build.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ jobs:
3131
- name: Run validation
3232
run: |
3333
python setup.py validate
34+
- name: Run tests for SQLAlchemy v1.4 (backward-compatibility)
35+
run: |
36+
# Install v1.4 for testing
37+
pip install "SQLAlchemy>=1.4,<2"
38+
python setup.py unit_tests --test-target tests/slack_sdk/oauth/installation_store/test_sqlalchemy.py && \
39+
python setup.py unit_tests --test-target tests/slack_sdk/oauth/state_store/test_sqlalchemy.py
3440
- name: Run codecov (only 3.9)
3541
run: |
3642
python_version=`python -V`

setup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,9 @@ def run(self):
337337
# used only under slack_sdk/*_store
338338
"boto3<=2",
339339
# InstallationStore/OAuthStateStore
340-
"SQLAlchemy>=1,<3",
340+
# Since v3.20, we no longer support SQLAlchemy 1.3 or older.
341+
# If you need to use a legacy version, please add our v3.19.5 code to your project.
342+
"SQLAlchemy>=1.4,<3",
341343
# Socket Mode
342344
# websockets 9 is not compatible with Python 3.10
343345
"websockets>=10,<11" if sys.version_info.minor > 6 else "websockets>=9.1,<10",

0 commit comments

Comments
 (0)