fix: version defaulting to 0.0.0.dev0#40
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 94.58% 94.55% -0.03%
==========================================
Files 11 11
Lines 203 202 -1
==========================================
- Hits 192 191 -1
Misses 11 11 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
Oh fascinating catch but a bummer that the automation magic goes away for now... Totally missed that this would fallback to the dev version by default!
.github/maintainers_guide.md
Outdated
| will live (create it if it does not exist) | ||
| - `git checkout -b future-release` | ||
| - `git commit -m 'version 1.2.3.dev0'` | ||
| - `git push future-release` |
There was a problem hiding this comment.
Always fascinating to see the ways to push upstream haha! No change needed, I'm just a big fan of
$ git push -u origin future-release
| env: | ||
| SLACK_CLI_HOOKS_VERSION: ${{ github.event.release.name }} |
filmaj
left a comment
There was a problem hiding this comment.
Some minor docs comments left but agreed with Ethan's point re: major downgrades, good test to add.
.github/maintainers_guide.md
Outdated
| [run the tests](#run-all-the-unit-tests). | ||
|
|
||
| 1. Create a new GitHub Release from the | ||
| Releases for this library are automatically generated off of git releases. |
There was a problem hiding this comment.
git has no concept of releases, only tags. Did you mean GitHub Releases here?
There was a problem hiding this comment.
@filmaj good catch 💯 currently the Github Action that deploys a new version of the project to Pypi is triggered by publishing a new Github Release, the instructions ask to create a tag along with the GitHub release
Should this action be triggered by the tag creation instead?
There was a problem hiding this comment.
I think Release creation is a nice underlying trigger, as it forces the maintainer to create a GitHub Release (which in turn will create a tag).
.github/maintainers_guide.md
Outdated
| Releases for this library are automatically generated off of git releases. Before | ||
| creating a new release, ensure that everything on the `main` branch since the | ||
| last tag is in a releasable state! At a minimum, | ||
| Releases for this library are automatically generated off of git releases. |
There was a problem hiding this comment.
Same thing here, git tags or GitHub Releases?
Co-authored-by: Fil Maj <maj.fil@gmail.com>
…i/python-slack-hooks into bill-fix-version-compare
Summary
This PR aims to fix #37, it appear the value being used to look up the version of the package on the users machine was defaulting to
0.0.0.dev0making thecheck_updatecommand unusable. These changes revert some of the automation introduced in #36 to fix this bug.Testing
slack create -t https://github.com/slack-samples/bolt-python-custom-function-templateRequirements
./scripts/install_and_run_tests.shafter making the changes.