Skip to content

feat(types): add underline to rich text section block element #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zimeg merged 2 commits into from
Oct 29, 2025
Merged

feat(types): add underline to rich text section block element #2414

zimeg merged 2 commits into from
Oct 29, 2025

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Oct 22, 2025

Summary

This PR adds underline to the rich text section block element style.

Reviewers

This snippet might be useful in testing:

const response = client.chat.postMessage({
  channel: channel,
  blocks: [
    {
      type: "rich_text",
      elements: [
        {
          type: 'rich_text_section',
          elements: [
            {
              type: 'text',
              text: 'this is important',
              style: {
                bold: true,
                underline: true,
              }
            },
          ],
        },
      ],
    }
  ]
});

Notes

🏁 This style has not been released to all teams yet! Hoping to have this ready to release when this does go public!

Requirements

@zimeg zimeg added this to the types@2.18.0 milestone Oct 22, 2025
@zimeg zimeg self-assigned this Oct 22, 2025
@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` labels Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.02%. Comparing base (9e73506) to head (5e40706).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files          40       40           
  Lines       11124    11124           
  Branches      713      713           
=======================================
  Hits        10348    10348           
  Misses        764      764           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.08% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

WilliamBergamin
WilliamBergamin approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise 🚀

mwbrooks
mwbrooks approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📏 Nice, thanks for adding underline support to Node!

@zimeg
Copy link
Member Author

zimeg commented Oct 29, 2025

@WilliamBergamin @mwbrooks Thanks so much! 🎁 ✨

@zimeg zimeg merged commit a8645bf into main Oct 29, 2025
56 of 57 checks passed
@zimeg zimeg deleted the zimeg-feat-types-rich-text-underline branch October 29, 2025 03:26
@vegeris vegeris modified the milestones: types@2.18.0, types@2.19.0 Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

@vegeris vegeris Awaiting requested review from vegeris

Assignees

@zimeg zimeg

Labels

enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:minor

Projects

None yet

Milestone

types@2.19.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zimeg @mwbrooks @WilliamBergamin @vegeris