-
Notifications
You must be signed in to change notification settings - Fork 679
docs: update package homepage to docs.slack.dev tools reference #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 39 39
Lines 10693 10693
Branches 692 692
=======================================
Hits 9920 9920
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lukegalbraithrussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful!!
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Notes for the wonderful reviewers kind!
| "url": "git+https://github.com/slackapi/node-slack-sdk.git" | ||
| }, | ||
| "homepage": "https://tools.slack.dev/node-slack-sdk", | ||
| "homepage": "https://docs.slack.dev/tools/node-slack-sdk/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ note: I don't believe a trailing slash causes problem during publish. I included it here to avoid optimistic redirects on click for now.
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
@lukegalbraithrussell @mwbrooks I like these links so let's merge this PR now. |
Summary
This PR updates package
homepagelinks to reference the redirects docs.slack.dev/tools pages for this SDK.Some other links were changed to more current pages too! 📚 ✨
Requirements