build: use latest biome schema version #2363
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 39 39
Lines 10693 10693
Branches 692 692
=======================================
Hits 9920 9920
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looks good to me, since dependabot keeps biome up-to-date. This may break on a major, but we can pin the schema if that happens.
🗳️ Generally, I lean toward pinning all dependencies to specific versions. If we don't, then we may want to at least consider a package-lock.json.
WilliamBergamin
left a comment
There was a problem hiding this comment.
Seems like a reasonable change 💯
If the packages biome file extend ../../biome.json do we need to define the schema in all child files?
|
@mwbrooks @WilliamBergamin Thanks both for the reviews! I agree this is an alright workaround for warnings but we should still investigate a more stable upgrade path...
For development dependencies I agree too! Minimum versions are nice for production dependencies to unlock the newest features in application code without causing conflicts between sub-dependencies too I believe?
I found my editor doesn't recognize a standalone For now I'll merge this but am once again curious about more stable versioning for follow up! 🎁 |
Summary
This PR prefers the
latestbiome schema version to avoid warnings in build scripts.Preview
Before changes
After changes
Notes
This might encourage us to keep following the latest version of
biomewith a minimum version requirement?node-slack-sdk/packages/cli-hooks/package.json
Line 58 in 893a37d
Although that isn't recommended...
I'd be interested in revisiting how we include some dependencies like
tscandbiometo use pinned versions later or instead of this change since unexpected updates to these would be an unfortunate reason to error?Requirements