Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Aug 26, 2025

Summary

This PR adds the Slack CLI version command to the test runner to confirm the right version is found in adjacent tests.

Requirements

@zimeg zimeg added this to the cli-test@2.2.0 milestone Aug 26, 2025
@zimeg zimeg self-assigned this Aug 26, 2025
@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` labels Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (18c4af4) to head (49eadaa).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.01%     
==========================================
  Files          38       39       +1     
  Lines       10676    10693      +17     
  Branches      692      692              
==========================================
+ Hits         9903     9920      +17     
  Misses        761      761              
  Partials       12       12              
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.80% <100.00%> (+0.05%) ⬆️
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 97.99% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@ewanek1
Copy link

ewanek1 commented Aug 27, 2025

LGTM 👏

@zimeg
Copy link
Member Author

zimeg commented Aug 27, 2025

@WilliamBergamin @ewanek1 I appreciate the kind reviews. I think these "adjacent" tests do too. Let's merge this!

@zimeg zimeg merged commit 54d06c7 into main Aug 27, 2025
57 checks passed
@zimeg zimeg deleted the zimeg-cli-test-feat-version branch August 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants