Skip to content

refactor(oauth): remove lodash.isstring from dependencies #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mwbrooks merged 1 commit into from
Jul 2, 2025
Merged

refactor(oauth): remove lodash.isstring from dependencies #2293

mwbrooks merged 1 commit into from
Jul 2, 2025

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jul 2, 2025

Summary

This PR removes an unused lodash package from the dependencies of @slack/oauth to prefer the typeof operator:

node-slack-sdk/packages/oauth/src/install-provider.ts

Line 367 in f1ebcc6

} else if (typeof existingCookies === 'string') {

Reviewers

Confirm tests continue to pass and no references exist to this import!

Notes

This package remains imported indirect through jsonwebtoken but that is automatic AFAICT:

$ npm ls lodash.isstring
@slack/oauth@3.0.3 ~/programming/tools/node-slack-sdk/packages/oauth
└─┬ jsonwebtoken@9.0.2
  └── lodash.isstring@4.0.1

Requirements

@zimeg zimeg added this to the oauth@3.0.3 milestone Jul 2, 2025
@zimeg zimeg requested a review from mwbrooks July 2, 2025 19:41
@zimeg zimeg self-assigned this Jul 2, 2025
@zimeg zimeg added semver:patch pkg:oauth applies to `@slack/oauth` dependencies Pull requests that update a dependency file labels Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (f1ebcc6) to head (466fd11).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          38       38           
  Lines       10607    10607           
  Branches      683      683           
=======================================
  Hits         9834     9834           
  Misses        761      761           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.74% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 97.97% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg mentioned this pull request Jul 2, 2025
Closed
2 tasks
mwbrooks
mwbrooks approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Good eye!

@mwbrooks mwbrooks merged commit 5cf7634 into main Jul 2, 2025
57 checks passed
@mwbrooks mwbrooks deleted the zimeg-refactor-oauth-remove-lodash branch July 2, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

Assignees

@zimeg zimeg

Labels

dependencies Pull requests that update a dependency file pkg:oauth applies to `@slack/oauth` semver:patch

Projects

None yet

Milestone

oauth@3.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg @mwbrooks