Added in timezone string property to timepicker block element in types package#1503
Merged
seratch merged 1 commit intoslackapi:mainfrom Jul 7, 2022
Merged
Conversation
misscoded
approved these changes
Jun 29, 2022
seratch
approved these changes
Jun 29, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Looks good to me but we should hold off merging this until the timing that the property is publicly available in the API documents.
Contributor
|
For the above reason, let me change this PR to draft mode. |
Contributor
Author
|
Sounds good to me! Thanks, Kaz! @seratch 🙌 |
Contributor
|
The server-side engineering team told me that this feature is ready for all clients now. Also, the API document site will be updated soon. Let me merge this PR now. Thanks for your contribution! @hello-ashleyintech |
9 tasks
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in Issue #1502, we need to add a new optional String property,
timezone, for the Timepicker element. This needs to be added to the@slack/typespackage.Requirements (place an
xin each[ ])