Skip to content

Add two admin APIs with binary response support#602

Merged
seratch merged 6 commits intoslackapi:mainfrom
seratch:new-admin-apis
Nov 12, 2020
Merged

Add two admin APIs with binary response support#602
seratch merged 6 commits intoslackapi:mainfrom
seratch:new-admin-apis

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Oct 30, 2020

This pull request adds two admin API support:

  • admin.analytics.getFile
  • admin.apps.clearResolution

admin.analytics.getFile API is completely different from the existing ones as it doesn't return text response body. To support this endpoint, I've updated the base clients and response classes.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Oct 30, 2020
@seratch seratch added this to the 1.3.0 milestone Oct 30, 2020
@seratch seratch self-assigned this Oct 30, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #602 (9d8c0bf) into main (b23eaaf) will decrease coverage by 0.52%.
The diff coverage is 32.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #602      +/-   ##
============================================
- Coverage     80.61%   80.09%   -0.53%     
- Complexity     2775     2782       +7     
============================================
  Files           313      314       +1     
  Lines          7683     7760      +77     
  Branches        663      672       +9     
============================================
+ Hits           6194     6215      +21     
- Misses         1113     1165      +52     
- Partials        376      380       +4
Impacted Files Coverage Δ Complexity Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 98.39% <ø> (ø) 8.00 <0.00> (ø)
...slack/api/methods/impl/AsyncMethodsClientImpl.java 94.83% <0.00%> (-1.05%) 340.00 <0.00> (ø)
...slack/api/methods/impl/AsyncRateLimitExecutor.java 54.94% <ø> (ø) 20.00 <0.00> (ø)
...admin/analytics/AdminAnalyticsGetFileResponse.java 3.22% <3.22%> (ø) 1.00 <1.00> (?)
.../com/slack/api/methods/impl/MethodsClientImpl.java 89.13% <45.45%> (-2.56%) 469.00 <5.00> (+5.00) ⬇️
...java/com/slack/api/methods/RequestFormBuilder.java 89.83% <100.00%> (+0.07%) 259.00 <2.00> (+2.00)
...pi/methods/metrics/impl/RedisMetricsDatastore.java 87.03% <0.00%> (-2.47%) 37.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23eaaf...9d8c0bf. Read the comment docs.

@seratch
Add two admin APIs with binary response support
e55bcba 
* admin.analytics.getFile
* admin.apps.clearResolution
@seratch seratch merged commit bdba0bf into slackapi:main Nov 12, 2020
@seratch seratch deleted the new-admin-apis branch November 12, 2020 23:43
@seratch seratch mentioned this pull request Nov 17, 2020
Merged
6 tasks
@seratch seratch mentioned this pull request Mar 22, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

@stevengill stevengill Awaiting requested review from stevengill

@aoberoi aoberoi Awaiting requested review from aoberoi

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch