Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1065 +/- ##
============================================
+ Coverage 76.80% 76.87% +0.07%
- Complexity 3733 3765 +32
============================================
Files 407 409 +2
Lines 11250 11384 +134
Branches 1128 1141 +13
============================================
+ Hits 8640 8752 +112
- Misses 1936 1948 +12
- Partials 674 684 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
16 tasks
7 tasks
WilliamBergamin
approved these changes
Oct 4, 2022
Contributor
WilliamBergamin
left a comment
There was a problem hiding this comment.
This looks good to me, slick work 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new way to upload files to Slack.
The legacy files.upload API endpoint now has severe performance issues as described in the following reports:
Slack platform team decided to unlock a new way to upload files using the following endpoints:
https://files.slack.com/upload/v1/***to upload the file content per fileThis pull request adds supports for the new endpoints, so that now the low-level APIs are available for developers. Having said that, going through the above process for uploading files requires many lines of code on 3rd party app side. Also, following all the steps can be confusing for developers.
For this reason, in addition to the low-level API supports, I propose to add MethodsClient#filesUploadV2 method as a wrapper of the whole file-upload operation. Here are the code examples demonstrating how it works:
Once we agree that we can go with this design, I will add the same one to other SDKs (Node, Python).
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.