Add timezone property to timepicker block element#1010
Merged
seratch merged 3 commits intoslackapi:mainfrom Jul 7, 2022
Merged
Add timezone property to timepicker block element#1010seratch merged 3 commits intoslackapi:mainfrom
seratch merged 3 commits intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
============================================
- Coverage 76.76% 76.67% -0.09%
+ Complexity 3688 3687 -1
============================================
Files 403 403
Lines 11120 11121 +1
Branches 1111 1111
============================================
- Hits 8536 8527 -9
- Misses 1909 1922 +13
+ Partials 675 672 -3
Continue to review full report at Codecov.
|
WilliamBergamin
approved these changes
Jul 7, 2022
Contributor
WilliamBergamin
left a comment
There was a problem hiding this comment.
Looks good to me!
Contributor
Author
|
Thanks for the review! |
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds timezone property to timepicker block element. see also: slackapi/node-slack-sdk#1502
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.