Add a type test verifying #922 is resolved by #878#923
Merged
seratch merged 2 commits intoslackapi:mainfrom May 19, 2021
Merged
Add a type test verifying #922 is resolved by #878#923seratch merged 2 commits intoslackapi:mainfrom
seratch merged 2 commits intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 66.22% 66.22%
=======================================
Files 13 13
Lines 1205 1205
Branches 355 355
=======================================
Hits 798 798
Misses 338 338
Partials 69 69 Continue to review full report at Codecov.
|
seratch
commented
May 17, 2021
| let options = []; | ||
| // Collect information in options array to send in Slack ack response | ||
| for (const result in results) { | ||
| for (const result of results) { |
Contributor
Author
There was a problem hiding this comment.
While adding the code in tests, I found that this is an obvious bug.
| // Example of responding to an external_select options request | ||
| app.options('external_action', async ({ options, ack }) => { | ||
| // Get information specific to a team or channel | ||
| // (modified to satisfy TS compiler) |
Contributor
Author
There was a problem hiding this comment.
modified for TS compilation - no need to do the same in JS
|
|
||
| if (results) { | ||
| // (modified to satisfy TS compiler) | ||
| let options: Option[] = []; |
Contributor
Author
There was a problem hiding this comment.
just for TS compatibility
10 tasks
mwbrooks
approved these changes
May 17, 2021
seratch
commented
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a type test verifying #922 is resolved by #878 pull request.
Requirements (place an
xin each[ ])