ESLint Config Migration: Disable max-classes-per-file rule#1054
Merged
filmaj merged 1 commit intotslint-to-eslintfrom Aug 23, 2021
Merged
ESLint Config Migration: Disable max-classes-per-file rule#1054filmaj merged 1 commit intotslint-to-eslintfrom
filmaj merged 1 commit intotslint-to-eslintfrom
Conversation
26 tasks
seratch
approved these changes
Aug 10, 2021
Contributor
seratch
left a comment
There was a problem hiding this comment.
I agree. For this project (and node-slack-sdk project too), we should disable this rule as it does not work for them at all.
misscoded
approved these changes
Aug 13, 2021
stevengill
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR disables the
max-classes-per-filerule. There are many situations you would want multiple classes per file, such as a generic errors module or test files that include helper mock classes. As such, I think it would be good to turn this rule off. Alternatively, we can customize the maximum number of classes to something higher.What do folks think?
Impact
Before
After
Requirements (place an
xin each[ ])