ESLint Config Migration: Object property names enclosed with quotes require no naming convention#1051
Closed
filmaj wants to merge 1 commit intotslint-to-eslintfrom
Closed
ESLint Config Migration: Object property names enclosed with quotes require no naming convention#1051filmaj wants to merge 1 commit intotslint-to-eslintfrom
filmaj wants to merge 1 commit intotslint-to-eslintfrom
Conversation
26 tasks
…nclosed with quotes do not have to adhere to any specific naming convention.
99ca57f to
f763727
Compare
Contributor
Author
|
Hmm, it seems like this PR is no longer needed as the targeted rule passes now on the base PR. Well, great, I guess! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR tweaks the naming convention rule such that object properties enclosed in quotes do not need to adhere to specific naming conventions. This is useful for things like specifying HTTP header names as properties on an object, since HTTP header names typically use a kabob-case naming convention (usually capitalized, too).
Impact
Before
After
Requirements (place an
xin each[ ])