Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

This PR turns off the @typescript-eslint/strict-boolean-expressions rule. While on the surface the intention of the rule makes sense ("prevent implicit casting to Boolean of conditional expressions"), in practice this rule gets in the way.

Consider the following real example from this code base, from ExpressReceiver.spec.ts:

const verifier = verifySignatureAndParseRawBody(noopLogger, signingSecretFn || signingSecret);

The error raised by this line is:

  426:68   error    Unexpected value in conditional. A boolean expression is required  @typescript-eslint/strict-boolean-expressions

Essentially, any values taking part in a short-circuit logical operation (like || or &&) must be a boolean. Therefore, the common pattern seen in JS/TS of using || as a means of declaring default values would always be invalid.

My suggestions is to remove this rule, as it does not seem to allow for customization to avoid the above scenario, but what does everyone else think?

Impact

Before

✖ 362 problems (173 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 358 problems (169 errors, 189 warnings)
  75 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.