For other use cases described in the rule document, I still see some value in consistent-return. Thus, I would like to explore alternative ways to avoid disabling this rule to all the code in the repo. However, I'm also not sure about the ways to settle this lint error in the stop() method. How about disabling this rule only for the stop() methods and other similar as long as they are not hundreds?

@seratch that sounds good. There are 9 occurrences of this rule failing, and from what I could tell, they are all in the various Receiver implementations, all follow the same general pattern seen by the stop example.

I think one possible solution would be to ensure that both the Receiver.stop and the underlying node HTTP server.close methods return a Promise, then we can pass Promises around to, I think, pass this rule. I can try my hand at an implementation tomorrow.

Sounds great! Thanks for your careful work here.

@seratch I attempted to implement fixes for this rule instead of removal in #1075. Perhaps that is a better choice than this PR.

@filmaj Yes, I agree. Let go with #1075 instead

Closing in favour of #1075