ESLint Config Migration: Add test-specific ruleset#1044
Merged
filmaj merged 1 commit intotslint-to-eslintfrom Aug 23, 2021
Merged
ESLint Config Migration: Add test-specific ruleset#1044filmaj merged 1 commit intotslint-to-eslintfrom
filmaj merged 1 commit intotslint-to-eslintfrom
Conversation
26 tasks
seratch
approved these changes
Aug 6, 2021
Contributor
seratch
left a comment
There was a problem hiding this comment.
💯 comment for reasoning 👍
46ec80b to
4723cc4
Compare
79ef148 to
fcbae2d
Compare
59e4a06 to
9b348fe
Compare
Contributor
Author
|
Thanks for your review @seratch; FYI I added two more rule changes (reminder: that only apply to
If you could let me know what you think about those, I would very much appreciate it 🙏 EDIT: 😆 @seratch nevermind you are too fast for me 😂 |
Contributor
|
@filmaj Both look good to me 👍 |
misscoded
approved these changes
Aug 13, 2021
stevengill
approved these changes
Aug 18, 2021
Allow use of "as Type" syntax for type assertions in test code. Dont force symbol descriptors in test code
9b348fe to
7b6be5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR adds test-code-specific rules:
prefer-arrow-callback rule- but only for test files (i.e.**/*.spec.ts). The use offunctionover arrow syntax actually came up when writing tests in one time in Mocha (see Add tests for SocketModeReceiver (#750) #1012 (review)). As such, we shouldn't have the linter recommend to use only arrow functions in test files, as that may lead to the same situation as in Add tests for SocketModeReceiver (#750) #1012.consistent-type-assertionsrule), to allow for theconst x = { ... } as Tover theconst x: T = { ... }syntax. The latter requires all properties of a type to be declared, whereas the former requires only the required properties to be defined. I believe theas Tsyntax is handy to have in test code.symbol-descriptorrule and allows for creatingSymbolobjects without a descriptor.Impact
Before
After
Requirements (place an
xin each[ ])