ESLint Config Migration: Remove no-inferrable-types rule#1041
Merged
filmaj merged 1 commit intotslint-to-eslintfrom Aug 23, 2021
Merged
ESLint Config Migration: Remove no-inferrable-types rule#1041filmaj merged 1 commit intotslint-to-eslintfrom
filmaj merged 1 commit intotslint-to-eslintfrom
Conversation
26 tasks
0cb5020 to
5d1368d
Compare
seratch
approved these changes
Aug 10, 2021
Contributor
seratch
left a comment
There was a problem hiding this comment.
Disabling this rule makes sense a lot to me. No need to be strict about this at all
misscoded
approved these changes
Aug 13, 2021
stevengill
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR turns off the
no-inferrable-typesrule. My thinking behind this is that, while extraneous, being specific about the type of a variable even when it can be inferred from its initialization value may be helpful to folks, especially those whom may be unfamiliar with TypeScript.Example code that failed this rule previously:
In the above, because the default value of
msis set to0, it can be inferred from the default value that the type ofmsisnumber. Thus, theno-inferrable-typesrule would fail.What do folks think?
Impact
Before
After
Requirements (place an
xin each[ ])