[WIP] ESLint Config Migration: Expand import/no-internal-modules allowlist#1032
Merged
filmaj merged 1 commit intotslint-to-eslintfrom Aug 23, 2021
Merged
[WIP] ESLint Config Migration: Expand import/no-internal-modules allowlist#1032filmaj merged 1 commit intotslint-to-eslintfrom
filmaj merged 1 commit intotslint-to-eslintfrom
Conversation
26 tasks
stevengill
approved these changes
Aug 4, 2021
81b873a to
bf75bc4
Compare
seratch
approved these changes
Aug 10, 2021
Contributor
seratch
left a comment
There was a problem hiding this comment.
src/index.ts has * exports from types/index.ts. Thus, I think this should be fine
misscoded
approved these changes
Aug 13, 2021
stevengill
approved these changes
Aug 18, 2021
…irectories to import submodules from.
bf75bc4 to
b9a869e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR expands the list of source directories that one may reach into its subdirectories to import individual submodules (details about the `import/no-internal-modules rule here).
The
src/receiversdirectory has no single export - so I think it is safe to allow it there (similar structure tosrc/middleware). I am less sure of thesrc/typesdirectory. What do you think @misscoded ?Impact
Before
After
Requirements (place an
xin each[ ])