server: Add support for dynamic lists in Skyhash #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've clearly been irresponsible and did a DF here. `UnsafeCell`s DO run the dtor (and doing the opposite introduced this bug)! Also: misc changes in the rust client upstream were made and the test code was adjusted for the same.
Member
Author
|
@glydr r+ |
glydr
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only supported lists in queries using the list syntax (
[?, ?]) but this prevents the use of lists with undecided capacities. Also, using a string buffer and adding it simply defeats the security measures that we enforce so strictly.To solve this, we now allow lists to be passed as a parameter in Skyhash.
✔️ By submitting this pull request, I agree to the CLA at: https://cla.skytable.io/skytable/skytable