check whether it exceeds the maximum value of an integer#2773
Merged
skylot merged 3 commits intoskylot:masterfrom Feb 4, 2026
Merged
check whether it exceeds the maximum value of an integer#2773skylot merged 3 commits intoskylot:masterfrom
skylot merged 3 commits intoskylot:masterfrom
Conversation
skylot
approved these changes
Feb 4, 2026
Owner
skylot
left a comment
There was a problem hiding this comment.
Thanks.
Although in most cases it shouldn't happen because we have several checks for entry sizes and also default jadx parser not support such big entries (we might need similar check at entry decoding).
Anyway, check is fine, and it is always better to fail earlier with clear error.
jadx-commons/jadx-zip/src/main/java/jadx/zip/parser/ZipDeflate.java
Outdated
Show resolved
Hide resolved
skylot
reviewed
Feb 4, 2026
jadx-commons/jadx-zip/src/main/java/jadx/zip/parser/ZipDeflate.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses a potential integer overflow vulnerability in JADX - ZIP parsing code. When processing maliciously crafted ZIP files, an
uncompressedSizevalue exceedingInteger.MAX_VALUE, causing undefined behavior during array allocation.