fix(gui): prevent unlimited recursion in text search (#2685)#2694
Merged
skylot merged 1 commit intoskylot:masterfrom Nov 6, 2025
Merged
fix(gui): prevent unlimited recursion in text search (#2685)#2694skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my understanding the part that causes the unlimited recursion of issue #2685 was responsible for continuing search for the beginning of a file, when the end of the text was reached (or the other way around when searching backward).
As RSyntaxTextArea
SearchContexthas thesearchWrapproperty which enabled searching exactly using that behavior we can get rid of the recursivesearchcall and let RSyntaxTextArea do the work.fixes #2685