fix: detect more for-each loops (also prevent issues with missing generics types)#2689
Merged
skylot merged 1 commit intoskylot:masterfrom Nov 5, 2025
Merged
Conversation
skylot
approved these changes
Nov 5, 2025
Repository owner
deleted a comment from
rupeshkumar7002h-creator
Nov 5, 2025
Repository owner
deleted a comment from
rupeshkumar7002h-creator
Nov 5, 2025
Repository owner
deleted a comment from
rupeshkumar7002h-creator
Nov 5, 2025
Owner
Yeah, that a very old test and it should be adjusted to new convention and use a common tests approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the PR for issue #2687 (for-each loop).
BTW: There is another possibly related unit test
jadx-core/src/test/smali/generics/MissingGenericsTypesTest.smali, that does not conform to the naming convention. I called my unit test fileTestMissingGenericsTypes2.smali, so renaming is possible without conflicts.