fix: avoid false positive throws (regression of PR #2475)#2636
Merged
skylot merged 1 commit intoskylot:masterfrom Sep 14, 2025
Merged
fix: avoid false positive throws (regression of PR #2475)#2636skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to fix a regression I introduced with PR #2475. In two cases a check for excluded exceptions was missing. This may cause compiler errors in overridden methods.
Steps to reproduce
Recompile the app https://saper-minesweeper.apk.gold/
There are errors in
LionheartGames.Saper.SaperActivitydue to thrown exceptions (false positives).Detailed instructions:
Download apk from https://apk.gold/download?file_id=263903/saper-minesweeper
Recompile with:
After applying the PR this app can be recompiled and installed without errors. Recompiled game is playable.