Skip to content

fix: avoid false positive throws (regression of PR #2475)#2636

Merged
skylot merged 1 commit intoskylot:masterfrom
nitram84:fix_regression_of_pr2475
Sep 14, 2025
Merged

fix: avoid false positive throws (regression of PR #2475)#2636
skylot merged 1 commit intoskylot:masterfrom
nitram84:fix_regression_of_pr2475

Conversation

@nitram84
Copy link
Copy Markdown
Contributor

I'd like to fix a regression I introduced with PR #2475. In two cases a check for excluded exceptions was missing. This may cause compiler errors in overridden methods.

Steps to reproduce

Recompile the app https://saper-minesweeper.apk.gold/

There are errors in LionheartGames.Saper.SaperActivity due to thrown exceptions (false positives).

Detailed instructions:

Download apk from https://apk.gold/download?file_id=263903/saper-minesweeper

Recompile with:

jadx -e Saper-1.4.apk 
cd Saper-1.4
# Workaround for R-file conflicts, R files should not be generated in recompilation mode. 
# This should be fixed for a better out-of-the box experience.
mv app/src/main/java/LionheartGames/Saper/R.java app/src/main/java/LionheartGames/Saper/R.java.bak
gradle wrapper --gradle-version 8.13
./gradlew assembleDebug

After applying the PR this app can be recompiled and installed without errors. Recompiled game is playable.

Copy link
Copy Markdown
Owner

@skylot skylot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thank you 👍

@skylot skylot merged commit d9da6a7 into skylot:master Sep 14, 2025
4 checks passed
@nitram84 nitram84 deleted the fix_regression_of_pr2475 branch November 4, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants