Merged
Conversation
ee265b6 to
15f3d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple minor UI fixes in a single PR since each fix is few lines long. Commits are enumerated accordingly:
Pinning/bookmarking a tab unsets preview flag, but the label is not repained.
Noticeable when closing active tab and opening it again without selecting other tabs in between. Tab opens but does not became selected.
Pinning currently active tab results in selecting nearby tab instead of keeping the selection on pinned tab.
I couldn't figure out how to quickly make preview tab permanently... Made it same as in Intellij IDEA by double clicking the tab. Additionally I'd personally prefer making tab permanent on tree node double click simultaneously with node expansion, but it may be confusing.
Preview tab label becomes default on settings change despite being in preview state.