fix: use proper newlines when generating cfg from backup#2592
Merged
skylot merged 1 commit intoskylot:masterfrom Aug 4, 2025
Merged
fix: use proper newlines when generating cfg from backup#2592skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #2588 there is an issue when generating the CFG. This PR fixes that issue by using
Matcher.quoteReplacement()as suggested in the Java documentation.I also noticed a bug where there is a missing space between "CFG for" and the function path in the title. I wasn't sure whether I should put that in a separate pull request.
I'm quite new to contributing to OSS, so I apologize if I don't know the proper procedures for all this.