New search options to search in text or binary resources#2526
Merged
Conversation
Contributor
|
@skylot im found bug - scrollToOffset work fine if already opened hexviewer |
…les as binary in search
Owner
Author
|
@MrIkso thanks, added selection of matching tab (by file content type) and data loading before scroll to pos. |
Contributor
|
@skylot nice, bug fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New checkboxes to add a
variableinto resource file filter field.$TEXTfor text files,$BINfor binary. Content type field added toResourceTypeenum.Filter field can be edited manually, checkboxes will add/remove variables without resetting user values.
$TEXTnow a default filter string for resources.Also, some improvement and fixes done to allow search in binary files:
Resolves issues from #2522