Skip to content

fix(gui): minor improved search dialog & small refactor for search fields#2510

Merged
skylot merged 3 commits intoskylot:masterfrom
MrIkso:improve_search_dilalog_and_fields
May 24, 2025
Merged

fix(gui): minor improved search dialog & small refactor for search fields#2510
skylot merged 3 commits intoskylot:masterfrom
MrIkso:improve_search_dilalog_and_fields

Conversation

@MrIkso
Copy link
Copy Markdown
Contributor

@MrIkso MrIkso commented May 24, 2025

This PR improve ui in Search dialog and maybe close #2365

  • Move all search opt icons to Icons common class
  • Use TextStandardActions in the same code style for search fields
  • Added to search dialog setting set file extetions for search, (dublicate from settings)
  • Added icons for regex and case sensitive search option
Preview

2025-05-24_21-37

@skylot
Copy link
Copy Markdown
Owner

skylot commented May 24, 2025

@MrIkso looks nice 🙂

Added icons for regex and case sendevire search option

Maybe Active tab only also show as icon (with same tooltip)?

Added to search dialog setting set file extetions for search, (dublicate from settings)

Super! We actually can remove that from settings (with default set to *), and that will also resolve #2365

@MrIkso
Copy link
Copy Markdown
Contributor Author

MrIkso commented May 24, 2025

Maybe Active tab only also show as icon (with same tooltip)?

maybe I'll try to find a suitable icon for this option

@MrIkso
Copy link
Copy Markdown
Contributor Author

MrIkso commented May 24, 2025

@skylot icon added
image

@skylot skylot merged commit 646ee2d into skylot:master May 24, 2025
4 checks passed
@MrIkso MrIkso deleted the improve_search_dilalog_and_fields branch May 24, 2025 20:10
@skylot
Copy link
Copy Markdown
Owner

skylot commented May 29, 2025

@MrIkso I made some improvements to search dialog in 6b54cde
I added resource file size filter, and remove these additional edit boxes if not needed, like for search in code, resources options obviously not needed. But making panel invisible not play good with grid box layout (added in this PR), because it will show empty spaces, so I switch it back to wrap flow layout. I add precise calculation of preferred size, so text in titled border not cut out, and input fields size is fine.
It will be nice if you can check my changes, maybe I break some of your intentions from this PR, or maybe you have some ideas for improvements 🙂

@MrIkso
Copy link
Copy Markdown
Contributor Author

MrIkso commented May 30, 2025

@skylot im found bug, when you use wrap flow layout

java_2oZTTrhoK3.mp4

@skylot
Copy link
Copy Markdown
Owner

skylot commented Jun 2, 2025

found bug, when you use wrap flow layout

@MrIkso I spent a lot of time but still not managed to fix this issue 😭
I also tried other layouts, but wrap layout fills better and allows reducing windows space usage (one line) if window is wide enough. So I will try harder to find a solution, will create a new issue for progress tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gui] Search Feature Can't Find .env Contents

2 participants