fix(gui): update resource.arsc nodes after opened tab with resource ids#2489
Merged
skylot merged 2 commits intoskylot:masterfrom May 17, 2025
Merged
fix(gui): update resource.arsc nodes after opened tab with resource ids#2489skylot merged 2 commits intoskylot:masterfrom
skylot merged 2 commits intoskylot:masterfrom
Conversation
…ds list by double click (fix skylot#2488)
skylot
approved these changes
May 17, 2025
Owner
skylot
left a comment
There was a problem hiding this comment.
Thanks. Update call here indeed fixed the issue, but looks like instead of calling load or loadTask, getCodeInfo() method was called directly from codepanel constructor. This is not correct behavior, also now hex view loaded even not visible which is unnecessary. I will look into these issues and will try to fix them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2488