Skip to content

Added dialog for select methods for generate frida snippet#2487

Merged
skylot merged 1 commit intoskylot:masterfrom
MrIkso:generate_snippet_for_methods
May 16, 2025
Merged

Added dialog for select methods for generate frida snippet#2487
skylot merged 1 commit intoskylot:masterfrom
MrIkso:generate_snippet_for_methods

Conversation

@MrIkso
Copy link
Copy Markdown
Contributor

@MrIkso MrIkso commented May 15, 2025

This PRs adds the feature to choose which methods to create a snippet for Frida. It also possibly fixes the bug that when there are many methods and one big snippet is generated for all of them, the window may be freeze(?)

image

@jpstotz
Copy link
Copy Markdown
Collaborator

jpstotz commented May 16, 2025

Does this PR replace the old way to create snippets? Because it can get pretty difficult selecting the desired methods from a small list in case the APK is obfuscated and all methods are named next to identical. Therefore I would not recommend to possibility that you can directly generate a snippet for the one method you have identified by it's code or references (through the method's context menu).

IMHO if you want to hook multiple methods frida-trace is the better option. And that the code blocks contain redundant code shouldn't be a problem even for developers without much experience.

@MrIkso
Copy link
Copy Markdown
Contributor Author

MrIkso commented May 16, 2025

Does this PR replace the old way to create snippets?

No, it only improves #2328

@skylot
Copy link
Copy Markdown
Owner

skylot commented May 16, 2025

@MrIkso thanks 👍

Does this PR replace the old way to create snippets?

@jpstotz this PR adds a method selection window for class snippet. This resolving issue with lots of methods in output snippet, but still has some room for improvement.

Some issues and possible improvements:

  • if no methods selected, nothing will be copied, but class snippet line is expected
  • now class snippet line added before every method (issue from previous PR). Class line should be added only once
  • bulk selection buttons like "Select All" and "Deselect All" maybe useful, also that way dialog will be closer to existing "Exclude package dialog"
  • since we have hotkey assigned for Frida snippet action it will be nice to support using only keyboard to select methods, now it is hard to select methods with only arrow keys.

@skylot skylot merged commit be1c024 into skylot:master May 16, 2025
4 checks passed
@MrIkso
Copy link
Copy Markdown
Contributor Author

MrIkso commented May 16, 2025

bulk selection buttons like "Select All" and "Deselect All" maybe useful

Hot keys from keyboard Ctrl+A worked for select/deselect all:)

@MrIkso MrIkso deleted the generate_snippet_for_methods branch May 23, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants