feat: add button to install desktop file directly from jadx-gui#2404
Merged
skylot merged 4 commits intoskylot:masterfrom Feb 1, 2025
Hidoni:feature/install-desktop-entry
Merged
feat: add button to install desktop file directly from jadx-gui#2404skylot merged 4 commits intoskylot:masterfrom Hidoni:feature/install-desktop-entry
skylot merged 4 commits intoskylot:masterfrom
Hidoni:feature/install-desktop-entry
Conversation
- correct comment - Add StartupWMClass
skylot
approved these changes
Feb 1, 2025
Owner
|
@Hidoni looks great! Thank you for your work 👍 |
skylot
requested changes
Feb 1, 2025
Owner
skylot
left a comment
There was a problem hiding this comment.
Found some possible improvement for start script and some security issues, please check 🙂
skylot
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address #1392.
While it would be ideal if all distros provided JADX and a matching desktop entry, this is unfortunately still not the case several years after the issue was first created. As someone who uses JADX on a distro without one, I know this is a convenience feature I appreciate JetBrains IDEs having and I think JADX could benefit from it too :)
I implemented this feature by adding a new button to the
Helpdropdown menu at the top of the screen which is only visible on systems where desktop files exist (UNIX, except for MacOS). It uses the standardized xdg commands for installing icons and desktop files to hopefully ensure maximum compatibility.While working on the PR I noticed several incorrect values in the already provided desktop file that I changed too: