Merged
Conversation
Owner
Sure, looks good to me, thanks 👍 Related to #1392. |
skylot
approved these changes
Jan 1, 2025
Contributor
Author
Thanks for the quick merge 👍 Regarding the linked issue, I'm happy that Jadx is packaged in Void Linux (and apparently in Arch too), so the amount of distros packaging Jadx are increasing slowly but continuouly :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
.desktopfile for the GUI which can be copied to/usr/share/applicationson Linux to have a desktop entry to start the program using an application launcher/menu instead of starting it via the terminal viajadx-gui. I'm not sure if there's a better place for it, I placed it in a newly createdcontribfolder now as that's what most projects do.This PR is for having a desktop file entry at Void Linux due to void-linux/void-packages#53772 (comment), as we'd like to upstream desktop files and not vendor them ourselves.
If there are suggestions for improvements, feedback is always welcome! Thanks.