fix: IfRegionMaker find the wrong outBlock#2385
Merged
skylot merged 2 commits intoskylot:masterfrom Dec 30, 2024
Merged
Conversation
skylot
approved these changes
Dec 30, 2024
Owner
|
@ewt45 looks good! Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr tries to solve the issue #2384
when checking whether the then/else block should be extracted as out block,
getPathCrossto get the cross point(outBlock) of the two blocks. if it's not null, the codes will simply compare out block with then/else block.allPathsFromIf.Inside the method
getPathCross:handlerBlock.getId()instead ofhandlerBlock.getDomFrontier(). this is to fix a test class failure after the changing above. I'm not sure if this will break other cases.combinedDF.clear(block.getId());in the while loop. it seems that this line is trying to remove the current block after next domFront blocks are added, but current block is stored atdomFrontBSrather thancombinedDF.after these changes, now decompiled result is much better
viewFacade = null;