fix: inner class parent is wrong when name formatted as Class$method$xxx#2364
Merged
skylot merged 1 commit intoskylot:masterfrom Dec 11, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inner class name format can be
Class1$InnerClass1. but it can also beClass1$method1$InnerClass1(example). In ClassInfo.splitAndApplyNames(), only the former situation is considered.This pr is trying to cover the latter situation. If the inner class ClassInfo see its parent class as
Class1$method1, parent classNode will not be found. In this caseresolveParentClass()will try to split it again, intoClass1andmethod1, make sureClass1exists and contains methodmethod1, then setClass1as inner class's parent.