gradle: handle non-final res ids for AGP >8.0.0#2362
Merged
skylot merged 1 commit intoskylot:masterfrom Dec 11, 2024
Merged
Conversation
skylot
approved these changes
Dec 11, 2024
Owner
|
@nitram84 looks good, thanks!
We can improve performance a little for jadx-cli by disabling such passes if Gradle export not requested. Also, if everything in jadx-gui is loaded from code cache new flag will be not set, we need somehow save such info with code cache. One possible way is to implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The android gradle plugin for jadx gradle export can't be updated to newer versions > 8.0.0 due to several issues. One issue e.g. is a compiler error when android resource identifiers are uses as constant expressions.
Example:
Decompile an app with like this, export sources to gradle, update AGP version manually (> 8.0.0) and recompile it:
With the current gradle export using a AGP version < 8.0.0 this class could be recompiled without any issues.
The solution is to set a property
android.nonFinalResIds=falseingradle.properties(see https://stackoverflow.com/questions/76430646/constant-expression-required-when-trying-to-create-a-switch-case-block).I introduced a new pass to detect these cases. For the new visitor I introduced also a new package
jadx.core.dex.visitors.gradlefor visitors only required for gradle export. For a refactored visitor for #1927 I would use the same package.Real world example:
See switch instruction in class
de.sellfisch.android.wwr.a.kof https://apkpure.com/who-becomes-rich/de.sellfisch.android.wwr/download/1.15.1