fix: check respectBytecodeAccModifiers before changing method access modifier in MarkMethodsForInline#2361
Merged
skylot merged 1 commit intoskylot:masterfrom Dec 9, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even when option "Respect bytecode access modifiers" is on, some method modifiers will still be changed.
bugged dex: 1.zip
i found that
Access modifiers changed fromis fromFixAccessModifiers.changeVisibility().it's a static method, so cannot use the boolean variable in the same class. Instead, the caller of
changeVisibility()should check the option byroot.getArgs().isRespectBytecodeAccModifiers()in the other place where
changeVisibility()is called (ClassModifier.java), the options is checked, so here we should check it too.