Skip to content

chore: update android attrs (API 35)#2318

Merged
skylot merged 1 commit intoskylot:masterfrom
pubiqq:update-android-attrs
Oct 25, 2024
Merged

chore: update android attrs (API 35)#2318
skylot merged 1 commit intoskylot:masterfrom
pubiqq:update-android-attrs

Conversation

@pubiqq
Copy link
Copy Markdown
Contributor

@pubiqq pubiqq commented Oct 23, 2024

No description provided.

@pubiqq pubiqq force-pushed the update-android-attrs branch from 974f15f to eb88e58 Compare October 23, 2024 20:14
@pubiqq pubiqq changed the title chore: update android attributes (API 35) chore: update android attrs (API 35) Oct 23, 2024
@pubiqq pubiqq force-pushed the update-android-attrs branch from eb88e58 to 0ec2274 Compare October 23, 2024 20:45
@skylot
Copy link
Copy Markdown
Owner

skylot commented Oct 24, 2024

@pubiqq thanks for update.
Although, it concerns me to see that too many IDs are shifted in res-map.txt. This means that these ids shouldn't be replaced with resource names. I will try to investigate this.

Related to #1020, #1035

@skylot skylot self-assigned this Oct 24, 2024
@pubiqq
Copy link
Copy Markdown
Contributor Author

pubiqq commented Oct 24, 2024

Nothing strange here: res-map.txt hasn't been updated for 5 versions of Android, and it still contains inaccessible resources that may not (and do not) have stable ids.

@skylot
Copy link
Copy Markdown
Owner

skylot commented Oct 25, 2024

and it still contains inaccessible resources that may not (and do not) have stable ids

This is sad, but looks like we can't do anything here.

Anyway, I can reproduce result res-map.txt, so it is fine 👍

@skylot skylot merged commit 6fa5d24 into skylot:master Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants