feat(gui): Limit search to a package#2284
Merged
skylot merged 8 commits intoskylot:masterfrom Sep 20, 2024
Merged
Conversation
Owner
|
@andyjsmith great work 👍 There is one minor possible improvement: split events processing for package search/verify with triggering search. So if package change we first search matching package object and if found than trigger big search. This way package field will be interactive and will notify about incorrect package even if "auto search" is disabled. Not sure if this really needed, so I might apply these changes myself later 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to limit search to a specific package (and sub-packages).
Often, you want to search for some code inside a specific package. The only way to do this currently is to add exclusions for all the packages you don't want, perform your search, and then include the packages again.
This PR adds:
This works for all search providers (except for resources, which just ignores the restriction if enabled).
Build passes with
gradlew clean build distThis is my first contribution here so please feel free to let me know your questions/thoughts/concerns!
Resolves #1408 and part of #818