Skip to content

feat(gui): Smali code folding#2233

Merged
skylot merged 4 commits intoskylot:masterfrom
Mino260806:code_folding_smali
Aug 1, 2024
Merged

feat(gui): Smali code folding#2233
skylot merged 4 commits intoskylot:masterfrom
Mino260806:code_folding_smali

Conversation

@Mino260806
Copy link
Copy Markdown
Contributor

Adds code folding for

  • .class
  • .method

image

@Mino260806
Copy link
Copy Markdown
Contributor Author

Mino260806 commented Aug 1, 2024

Screenshot_2024-08-01-18-46-35-414_com.github.android.jpg

I think this needs another method visitPatternStartOffsets() (uses matcher.start() not matcher.end())

Sorry for bad formatting I'm on phone

Edit: same for getStartMethodStartOffsets, it's my fault

@skylot
Copy link
Copy Markdown
Owner

skylot commented Aug 1, 2024

@Mino260806 sorry, I undo method extract, because these methods are all different now 🙂

Edit:
Also, it is funny that it is still working well with any start/end offset 🤣

@skylot skylot merged commit 1669200 into skylot:master Aug 1, 2024
@Mino260806 Mino260806 deleted the code_folding_smali branch August 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants