Merged
Conversation
Contributor
Author
|
It would be nice to write some unit tests for this, but I don't know how to do that yet :( |
skylot
approved these changes
Jul 8, 2024
Owner
|
@iscle look good.
Well, for good test we need actually execute xposed, but this is need emulator and so is too much hassle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues when generating Kotlin Xposed code. The function types were not generated correctly for primitive types and for non common java types.
For example:
This change also affects generated Java code in that now all, except some specific, classes will be in string form instead of ending in ".class".
The implementation was also converted to Kotlin to make it a bit cleaner and nicer to follow :) I hope you don't mind!