Allow to check for unstable releases#2200
Merged
skylot merged 3 commits intoskylot:masterfrom Jun 11, 2024
Merged
Conversation
Contributor
Author
|
It looks like the checks have not passed due to an internal github error while processing the jobs @skylot |
skylot
approved these changes
Jun 11, 2024
Owner
|
@iscle looks good 👍
Manual re-run didn't help, looks like github issues not fixed yet. Will try to run again later. |
| if (currentVersion.equals(latestRelease.name, ignoreCase = true)) return null | ||
| if (VersionComparator.checkAndCompare(currentVersion, latestRelease.name) >= 0) return null | ||
|
|
||
| LOG.info("Found new jadx version: {}", latestRelease) |
Check failure
Code scanning / CodeQL
Log Injection
| if (newestArtifact != null && currentArtifact != null) break | ||
| } | ||
|
|
||
| LOG.debug("Current artifact: {}, newest artifact: {}", currentArtifact, newestArtifact) |
Check failure
Code scanning / CodeQL
Log Injection
| if (newestArtifact != null && currentArtifact != null) break | ||
| } | ||
|
|
||
| LOG.debug("Current artifact: {}, newest artifact: {}", currentArtifact, newestArtifact) |
Check failure
Code scanning / CodeQL
Log Injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the Jadx updater to check for unstable releases. This will be useful for a later PR I'm working on which will allow for auto-updates, without the need to manually download the zip and extract it.
Many of us are using the unstable build as stable builds typically take a lot of time to be released and we always want the latest fixes and features (and bugs :P)
In a future PR which will be based in this code, I will add the option for jadx to auto-update just like other software do.
A settings option has been added to choose between the STABLE release channel (default, as always has been) or UNSTABLE (new behavior).
I chose to convert the code to kotlin since it looks a bit cleaner and has convenient features when handling Closeables and null checking.