fix(gui): support filtering files with multiple extensions in file dialog#2185
Merged
skylot merged 2 commits intoskylot:masterfrom May 19, 2024
Merged
fix(gui): support filtering files with multiple extensions in file dialog#2185skylot merged 2 commits intoskylot:masterfrom
skylot merged 2 commits intoskylot:masterfrom
Conversation
skylot
approved these changes
May 19, 2024
Owner
skylot
left a comment
There was a problem hiding this comment.
Not sure why you use delegate of FileNameExtensionFilter, because it just uses provided description internally.
Everything else looks good, thanks 👍
Contributor
Author
Hmm... the code I put in description is exactly part of the thanks for merging : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2184
After this commit:

The origional filter uses the last segment split by
.from file name to match files, so extensions like.jadx.ktswon't be accepted