fix(xml): fix regression - use parent attibute only for styles#1815
Merged
skylot merged 1 commit intoskylot:masterfrom Apr 10, 2023
Merged
fix(xml): fix regression - use parent attibute only for styles#1815skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
skylot
approved these changes
Apr 10, 2023
Owner
|
@nitram84 thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry, my previous commit 378c747 introduced a regression. 378c747 added an empty parent attribute to arrays, plurals and attrs. This commit adds a check for type "style" to restore the previous behavior.