core: Implemented parsing RES_TABLE_TYPE_LIBRARY chunks#1664
Merged
skylot merged 2 commits intoskylot:masterfrom Sep 10, 2022
Merged
core: Implemented parsing RES_TABLE_TYPE_LIBRARY chunks#1664skylot merged 2 commits intoskylot:masterfrom
skylot merged 2 commits intoskylot:masterfrom
Conversation
Collaborator
Author
|
Now decoding of the provided resources.arsc seems to fully work - and it still works with other APK files, at least the ones I have tried ;) @skylot From my point of view this PR is ready to be merged. |
skylot
approved these changes
Sep 10, 2022
Owner
|
@jpstotz thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1663
Afterwards it is possible to load the provided sample of #1663 without errors, but the loaded resources in jadx-gui are not what I would expect for a 3.5MB resources.arsc file:
Additionally most of the shown xml resource entries have next to no content. Therefore I assume that the current state of this PR is one step towards fixing this issue, but at the moment it seems to be incomplete and I don't yet understand what is the problem (thus the draft state).