Remove unnecessary Parcelize annotations after Navigation3 migration#47
Merged
Conversation
skydoves
approved these changes
Nov 29, 2025
skydoves
left a comment
Owner
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Remove
@Parcelizeannotation andParcelableinterface from model classesas they are no longer needed after migrating to Navigation3.
Unlike Navigation2, Navigation3 stores arguments directly in memory using
SnapshotStateListinstead of Bundle. Therefore,
@Serializableannotation alone is sufficient, making@Parcelizeredundant.reference)
https://android-developers.googleblog.com/2025/05/announcing-jetpack-navigation-3-for-compose.html
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation3/navigation3-runtime/src/commonMain/kotlin/androidx/navigation3/runtime/NavBackStack.kt
🛠 Implementation details
Describe the implementation details for this Pull Request.
✍️ Explain examples
Explain examples with code for this updates.
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.