Conversation
a2959e9 to
7d14926
Compare
|
TODO still relevant or is this ready for review @rmulhol ?` |
Author
Still relevant but I'll take care of it soon |
added 3 commits
January 8, 2020 13:14
- not very practical to run and not maintained, removing to reduce clutter - also removes other unused code
- No longer need multiple versions of core data structures without full sync version
7d14926 to
bf0b512
Compare
yaoandrew
approved these changes
Jan 10, 2020
yaoandrew
left a comment
There was a problem hiding this comment.
Wow.. great job. It looks so much cleaner when we remove some of this cruft and clean up the namespace.
| This is accomplished through the use of the `headerSync`, `fullSync`, or `coldImport` commands. | ||
| These commands are described in detail [here](documentation/data-syncing.md). | ||
| This is accomplished through the use of the `headerSync` command. | ||
| This command is described in detail [here](documentation/data-syncing.md). |
| Expect(len(logs)).To(Equal(0)) | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
More of a general question, are these deleted test cases only needed for fullsync?
elizabethengelman
approved these changes
Jan 13, 2020
elizabethengelman
left a comment
There was a problem hiding this comment.
Nice work, this cleans things up a lot! 🌟
| @@ -1,19 +0,0 @@ | |||
| -- +goose Up | |||
| CREATE TABLE public.uncles ( | |||
There was a problem hiding this comment.
this table is no longer needed because we would only even sync an uncle through the fullSync, is that right?
yaoandrew
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking this code should be removed since we don't recommend using it and aren't actively maintaining it. Hoping that clearing out the clutter will make the codebase more nimble and assist with creating more helpful documentation.