Skip to content

VDB-1001 use vdb InsertionModel for vow fess#32

Merged
elizabethengelman merged 4 commits intostagingfrom
vdb-1001-vow-fess
Dec 4, 2019
Merged

VDB-1001 use vdb InsertionModel for vow fess#32
elizabethengelman merged 4 commits intostagingfrom
vdb-1001-vow-fess

Conversation

@elizabethengelman
Copy link
Copy Markdown
Contributor

No description provided.

@elizabethengelman elizabethengelman changed the title Vdb 1001 vow fess VDB-1001 vow fess Dec 3, 2019
@elizabethengelman elizabethengelman changed the title VDB-1001 vow fess VDB-1001 use vdb InsertionModel for vow fess Dec 3, 2019
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

constants.HeaderFK: log.HeaderID,
Id: bidId.String(),
constants.HeaderFK: log.HeaderID,
Id: bidId.String(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly needs a gofmt ./...?

@elizabethengelman elizabethengelman force-pushed the vdb-1001-vow-fess branch 2 times, most recently from 997db4e to 8deecbe Compare December 3, 2019 22:44
constants.HeaderFK, "tab", constants.LogFK,
TableName: constants.VowFessLabel,
OrderedColumns: []event.ColumnName{
constants.HeaderFK, constants.TabColumn, constants.LogFK,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event.HeaderFK etc

Copy link
Copy Markdown
Contributor Author

@elizabethengelman elizabethengelman Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch! updated in 3e1258c

},
ColumnValues: shared.ColumnValues{
ColumnValues: event.ColumnValues{
"tab": "1337",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@elizabethengelman elizabethengelman merged commit b2a8e1a into staging Dec 4, 2019
@elizabethengelman elizabethengelman deleted the vdb-1001-vow-fess branch December 4, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants