(VDB-1284) Add LogTake event transformer#166
Merged
Conversation
rmulhol
commented
Apr 16, 2020
| ) | ||
|
|
||
| type LogTakeEntity struct { | ||
| Id common.Hash |
Contributor
Author
There was a problem hiding this comment.
For some reason I couldn't get bytes32 id to decode into a *big.Int here - which is weird because it works fine for LogMake. Afaict the only difference is that the id is in the data rather than the topics here, so either that matters or I'm doing something wrong
Contributor
There was a problem hiding this comment.
Huh, that does seem peculiar! I like what you ended up with though 👍
a73fcd0 to
b487a7f
Compare
gslaughl
approved these changes
Apr 17, 2020
| ) | ||
|
|
||
| type LogTakeEntity struct { | ||
| Id common.Hash |
Contributor
There was a problem hiding this comment.
Huh, that does seem peculiar! I like what you ended up with though 👍
| } | ||
| transformer := initializer.NewTransformer(db) | ||
|
|
||
| oasis_two_address := constants.GetContractAddress("OASIS_MATCHING_MARKET_TWO") |
Contributor
There was a problem hiding this comment.
Just curious why we're snake-casing this var?
| func MedianDissSingleSignature() string { return getLogNoteTopicZero(medianDissSingleMethod()) } | ||
| func MedianKissBatchSignature() string { return getLogNoteTopicZero(medianKissBatchMethod()) } | ||
| func MedianDropSignature() string { return getLogNoteTopicZero(medianDropMethod()) } | ||
| func MedianKissBatchSignature() string { return getLogNoteTopicZero(medianKissBatchMethod()) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.