Add the Content-Base hedaer to the default template#96
Add the Content-Base hedaer to the default template#96skx merged 2 commits intoskx:masterfrom StayPirate:template_link
Conversation
This field is often used to provide a direct link to the feed item by some MUA. Thunderbird is one of those which behaves like that.
|
I don't see a problem with that change. That said we already have code which is designed to convert relative links to absolute ones, which is here. You might be describing a different thing - the behaviour of the mail client - but the actual content should already contain everything as absolute via the rewriting mentioned above. Will look in more detail this evening, in the meantime thank-you for your contribution :) |
Right, I'm only talking about how MUAs render emails. According to your statement, I now think that this PR should not introduce any weird behavior.
My pleasure, I consider this project a little treasure 👍🏼. So, thank you. |
Do not add item's link to the body since it is shown in the rendered headers.
|
The latter commit removes the item's link within the email body (text and html). This probably needs to be taken with a grain of salt because if the MUA (email client) does not intentionally show the I found this useful since I use Thunderbird, which in turn reports the link as the |
|
Yeah removing the links would be a mistake for the MUAs that don't show the content of the I'll merge the header-change in, but not the second commit. |
I figure out that this header is often used to highlight a direct link to the feed item by some MUA. Thunderbird is one of those.
A screenshot without the
Content-Baseheader set:A screenshot with the
Content-Baseheader set:N.B. Since I'm not a HTML expert, I'd like to hear some feedback about this change. Could this badly impact some emails? From its definition:
I see this header might change how relative paths are resolved within the email's body.